search

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.05k stars 520 forks source link

Modifying TX-IQ-CAL value breaks RX Audio in the Microphone app #2006

Closed NotherNgineer closed 4 months ago

NotherNgineer commented 4 months ago

Describe the bug.

When RX Audio is enabled in the Microphone app, modifying the TX-IQ-CAL value causes the received audio to go silent (just hear static).

Reproduction

For testing, I was listening to a radio station in WFM mode. And change in the TX-IQ-CAL value causes the audio to go silent (even if the value is changed back). To get RX audio to work again afterwards, the "RX audio" checkbox can be turned off & on, or the app can be restarted.

Expected behavior

Audio reception should continue to work after the TX-IQ-CAL field is modified.

Environment/versions

Latest nightly FW version n240316

Anything else?

@Brumi-2021 fyi

(Also, FYI, due to the unsynchronized circular audio DMA output buffer, it is often necessary to toggle "RX audio" off and on to avoid garbled audio. That is a separate issue.)

gullradriel commented 4 months ago

In case like that the usual fix is to force an audio_stop & audio_start if audio was on before changing the IQ value

gullradriel commented 4 months ago

I fixed it:

https://github.com/portapack-mayhem/mayhem-firmware/pull/2007

Brumi-2021 commented 4 months ago

Thanks for finding it Later night or tomorrow I will try to check about it . Maybe there is a a more simple way to fix it inside driver side.

NotherNgineer commented 4 months ago

Thanks for finding it Later night or tomorrow I will try to check about it . Maybe there is a a more simple way to fix it inside driver side.

@Brumi-2021, yes, please see #2008.