search

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.05k stars 520 forks source link

Compiler WARNING: External code address #2032

Closed NotherNgineer closed 3 months ago

NotherNgineer commented 3 months ago

Describe the bug.

When building the firmware, an error message pops up: WARNING: External code address 0xadb9xxxx at offset 0xb0fbc in portapack-h1_h2-mayhem.bin

Reproduction

Build firmware from source and view make output. Observed using GCC 9.3.1 and latest firmware, but may vary depending on GCC version.

Expected behavior

No warning message and no Guru fault

Environment/versions

No response

Anything else?

This message could be a false positive, or could be indicating that the text_entry code in firmware (specifically the text_prompt function) is trying to execute some code in the external TEDI/LCR app. If it's a real issue, a Guru fault may occur when entering text.

NotherNgineer commented 3 months ago

Looks like a false positive, but not sure what to do about it.

fyi A false positive can be detected by changing the app's address in external.ld and rebuilding. If the address in the error message changes accordingly, then it's a real error. In this case, the error message still said 0xadb96ef0 when no external apps were using that 0xadb9xxxx region, implying it's a false positive.