search

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.02k stars 519 forks source link

move the no ext app tile to forward #2047

Closed zxkmm closed 3 months ago

zxkmm commented 3 months ago

Move the ext app missing hint tile forward.

maybe can do same with flash err msg (but i won't do it).

Feel free to comment if you think this is not necessary. :)

NotherNgineer commented 3 months ago

I like the added exclamation point to "Notice!" but I don't think the "External apps missing" text is going to reduce the number of confused users plus I don't like that it's hiding the title bar icons.

htotoo commented 3 months ago

I like the latest edition of this pr

NotherNgineer commented 3 months ago

It would help if you could add a screenshot to the PR or put test version on Discord. I would like to see what the updated screen looks like (I'll build it myself but it will take a bit longer)

zxkmm commented 3 months ago

It would help if you could add a screenshot to the PR or put test version on Discord. I would like to see what the updated screen looks like (I'll build it myself but it will take a bit longer)

Ohhhh wait, no need to build, I'll upload the test bin now. Sorry

zxkmm commented 3 months ago

test fw: https://discord.com/channels/719669764804444213/721387120421240872/1222912715635294229

I removed the icon of this tile, cuz i think this can make it more noticeable (instead of making non-english speaker user saw/recongnize it as an app) but feel free to against this. I'm not quite a visual designer so my point could be wrong

Sorry that i was just thinking this kind of small change ain't need tests

zxkmm commented 3 months ago

20240328_222049

NotherNgineer commented 3 months ago

I like that the "blacklist" is still supported, so I can hide this notice by putting "<Notice!>" in the blacklist file.

Is there any need for the less-than < and greater-than > symbols? IMO, I think Notice! without them would look better on the screen.

Also, I'm not sure that I like the placement of the Notice when the Back button is enabled on the menu. The Back button has always been in the upper left position when enabled, but it's shifted now: SCR_0089

zxkmm commented 3 months ago

Is there any need for the less-than < and greater-than > symbols? IMO, I think Notice! without them would look better on the screen.

I was planning to attract as much attention as possible, but if you think we don't need them, i can remove.

Also, I'm not sure that I like the placement of the Notice when the Back button is enabled on the menu. The Back button has always been in the upper left position when enabled, but it's shifted now

Thanks! I'll fix that now. I forgot that part.

zxkmm commented 3 months ago

Back button fixed.

NotherNgineer commented 3 months ago

Is there any need for the less-than < and greater-than > symbols? IMO, I think Notice! without them would look better on the screen.

I was planning to attract as much attention as possible, but if you think we don't need them, i can remove.

I don't know if we need to take a vote on this, but personally I think it looks better without the <> as in the screenshot below, so I would remove them:

SCR_0090

zxkmm commented 3 months ago

No need to vote for this. I removed it.

zxkmm commented 3 months ago

Thank you!