search

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.02k stars 519 forks source link

Add beep option to other apps #2053

Closed NotherNgineer closed 3 months ago

NotherNgineer commented 3 months ago

Description of the feature you're suggesting.

Other apps could use an optional beep when a packet is received, such as Pocsag, ERT, Weather, and TPMS.

Anything else?

No response

NotherNgineer commented 3 months ago

I wonder if this option should be on the title bar.

htotoo commented 3 months ago

I would like to have it in the settings menu, not the title bar.

NotherNgineer commented 3 months ago

I agree that having it on the title bar probably isn't necessary since we already have a mute button on the title bar and that should be enough for most apps.

But do you think we need the "beep on packet" option to be configurable for each app separately, or is it sufficient to have a single "beep on packet" setting stored in pmem that applies to every app?

htotoo commented 3 months ago

Beep on packet settings per app would take a lot screen space i think, and can't afford that on every app (a lot is crowded already) I think the "global" setting, with the speaker title bar icon would be enough.

NotherNgineer commented 3 months ago

In PR #2058, I'm proposing to modify the Settings -> Audio screen to add this, per feedback above.

NotherNgineer commented 3 months ago

I was going to add support to SubGHzD too, but there isn't space for a larger baseband image currently.

I didn't add it to BLE RX app yet either -- BLE packet frequency is so high at least near me (even more than ADSB RX) that it might not be useful.

I'm going to mark this one as completed now.

gullradriel commented 3 months ago

Nice work