portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.02k stars 519 forks source link

Configurable Root folder idea #2057

Closed NotherNgineer closed 3 months ago

NotherNgineer commented 3 months ago

Description of the feature you're suggesting.

Perhaps the root folder could be configurable in Settings (default would be "/" as it is now) and the setting could be stored in a file in the real root of the SD card. That way multiple SD card images could be placed on the SD card and the user could switch between them. Before the user downloads a new SD card image, they could rename the old folder to make sure that no user files are overwritten.

This setting would apply to all apps, but File Manager should still be able to see the entire SD card contents, so that a user could browse and pick a file from anywhere on the SD card, and move folders between them.

This could perhaps be a possible alternative to PR #1967 and PR #1968 (which were meant to prevent user files from getting overwritten when a new SD card image was downloaded).

Of course older firmware wouldn't support this and would always assume that the root directory was "/" after a firmware downgrade, but there would be no incompatibility issue with firmware upgrades, unlike in the PR's mentioned above.

(This could additionally be helpful for users that incorrectly downloaded their files in an "SDCARD" folder instead of to the root; they could simply configure the root folder name to match whatever folder they unzipped the contents into.)

Anything else?

No response

htotoo commented 3 months ago

zxkmm's solution seems easier by the users perspective, and from the devs (eg updater) too. I know that would require a big change on the first version update, but would be easier to manage in the long run.

NotherNgineer commented 3 months ago

Withdrawing suggestion