search

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2/H4
https://hackrf.app
GNU General Public License v3.0
3.46k stars 561 forks source link

Beep-on-packets support in Settings, ERT & Sonde apps #2058

Closed NotherNgineer closed 7 months ago

NotherNgineer commented 7 months ago
  1. Added "Beep on RX Packets" setting under Settings -> Audio as discussed in #2053 (setting to be stored in pmem).
  2. Modified Radiosonde app to use the above setting (eliminating Beep checkbox in Radiosonde app itself -- to avoid conflicting settings).
  3. Added beep support to ERT app (including volume control).

Note: If Beep is desired in some apps but not in others, set "Beep on RX Packets" to True, and turn down the volume to 0 in apps where the beep is not wanted.

(Support for beep-on-RX-packet in other apps to follow in separate PR's)

This PR should not affect beep settings in the the Level and Looking Glass apps (technically these apps are not even looking for "packets").

SCR_0091

Test firmware on Discord: https://discord.com/channels/719669764804444213/722101917135798312/1223324351667896450

gullradriel commented 7 months ago

Sounds good. Do you prefer to do some separated PR's for the on packet beep support?

NotherNgineer commented 7 months ago

Sounds good. Do you prefer to do some separated PR's for the on packet beep support?

If it sounds good, I'll go ahead and add beep support to some apps in this PR. I've changed it to a Draft until then. Thanks.

NotherNgineer commented 7 months ago

I've updated this PR to include ERT and Radiosonde support for this new "Beep on RX packet" setting, and marked the PR "ready to review". To avoid making this PR any larger, I propose to implement beep-on-packet support in additional apps in future follow-on PR's.