portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2/H4
https://hackrf.app
GNU General Public License v3.0
3.48k stars 561 forks source link

USB, LSB not working. Only DSB #206

Closed catalinalb closed 2 years ago

catalinalb commented 4 years ago

After updateing to v 1.2.3 from v 1.2.2, in Recieve->Audio->AM I can select USB or LSB but the waterfall is still showing the DSB.

Same with the CW mode.

This feature was working well on previos version.

For those who don´t know USB is Upper Side Band and LSB is Lower Side Band. CW - verrry narrow band for Morse Code.

Thank you

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/93355821-usb-lsb-not-working-only-dsb?utm_campaign=plugin&utm_content=tracker%2F182166508&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F182166508&utm_medium=issues&utm_source=github).
eried commented 4 years ago

Please make a video of the problem in 1.2.3 and show how it works on 1.2.2? there was no changes on that part in that version

catalinalb commented 4 years ago

Yes I will do that but Is it safe to downgrade?

eried commented 4 years ago

Yes, it is safe.

catalinalb commented 4 years ago

Hi, So I did install the version 1.2.2 and is the same. Good thing is that I can hear on the jack output that the selection is happening but it´s just about the waterfall that is not beeing shown properly. This was working before the update. I have attached some screenshots that I´ve edited so you can understand better what I mean. Also here is the video showing the both versions: https://www.youtube.com/watch?v=xMDTA-DSbMI I hope someone can address this issue.

Thank you.

DSB both sides USB the right way LSB the right way

eried commented 4 years ago

In releases you can browse back old versions, if you find the one that works, please post the screenshot that looks like the one you remember. There I can check what actually changed

euquiq commented 4 years ago

Hi @catalinalb ! What you are experiencing is correct. It's because of this pr:

https://github.com/eried/portapack-mayhem/pull/150

Although you can hear the correct mode, you now "see" the whole range at all times.

I wouldn't know with "all authority" if this is correct, but it seems nicer than just cut off the rest of the spectrum, only because you chose USB / LSB or CW. I would say that it is better to LISTEN into your selection, but SEE the whole range.

Of course, maybe it is a matter of opinions. Maybe it needs to be reverted into the older more visually impaired version. At least now you know it is not an "BUG" but it is "BY DESIGN".

strijar commented 4 years ago

That's right - now you can see the entire "band", but only the filtered area is heard. Misleading green filter stripe indicator. Over time, I will redo it so that it points correctly in different modes (DSB/LSB/USB/CW)

joyel24 commented 3 years ago

It can be a good idea to have a rectangle in the waterfall showing the selection of the corresponding mode in the spirit of this image (from a websdr). https://i.imgur.com/XTWy3LGl.png

ArjanOnwezen commented 2 years ago

In 1.4.x you can see a green stripe indicating USB/LSB/DSB 16388931861486090971923837159400 Closing this issue, since USB/LSB mode is working fine