search

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.01k stars 518 forks source link

fix a weird line if we have set menu color #2158

Closed zxkmm closed 1 month ago

zxkmm commented 1 month ago

this PR aim to fix that the "Menu Color" feature have a not quite elegant line of button grid top and when i was writing this, i think we can have a better global theme set, should be beautiful.

after discussion, we can decide if we agree to cost some SPI flash (we need to include pmem to Style file) to have a Style class impl to always match the theme color, which can set title bar color and status bar color and button color to match the theme i gave up the second plan cuz idk how to do the style things.

zxkmm commented 1 month ago

this seems impact the outline of other buttons, that maybe not quite elegant. maybe we should do the global theme thing