Closed zxkmm closed 2 weeks ago
Originally found by @htotoo
The system (or only UI, or UI caused system) got lagging appeared after trivial random code edit. for example:
return
Seems not related to whether external apps and standalone apps exist or not
make clean or ninja clean, then build won't make differences, but for test, better clean before building
https://discord.com/channels/719669764804444213/1301516615212470343
firstly found after #2302 were merged, AKA 8d1fb7cb66e5fae2e6d39ae06e0df38a669cf8b1 , fixed by workaround in #2307
appeared again in the halfway of work in #2331 but fixed in same PR by use bool instead of return
appeared again in the halfway of work in #2333 but also fixed in same PR by use bool instead of return
Originally found by @htotoo
A. what happened
The system (or only UI, or UI caused system) got lagging appeared after trivial random code edit. for example:
return
in a function that should return there, became lagging, and use a bool to bypass following code instead of using return, weirdly fixed.B. how can tell if current firmware has this issue
C. what we currently found
1.
Seems not related to whether external apps and standalone apps exist or not
2.
make clean or ninja clean, then build won't make differences, but for test, better clean before building
D. related talk:
https://discord.com/channels/719669764804444213/1301516615212470343
E. discover log
1.
firstly found after #2302 were merged, AKA 8d1fb7cb66e5fae2e6d39ae06e0df38a669cf8b1 , fixed by workaround in #2307
2.
appeared again in the halfway of work in #2331 but fixed in same PR by use bool instead of
return
3.
appeared again in the halfway of work in #2333 but also fixed in same PR by use bool instead of
return