portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2/H4
https://hackrf.app
GNU General Public License v3.0
3.53k stars 568 forks source link

System became lagging randomly after trivial code change #2345

Closed zxkmm closed 2 weeks ago

zxkmm commented 2 weeks ago

Originally found by @htotoo

A. what happened

The system (or only UI, or UI caused system) got lagging appeared after trivial random code edit. for example:

  1. add one more item in an array, it became lagging, but deleted that item fixed.
  2. add an return in a function that should return there, became lagging, and use a bool to bypass following code instead of using return, weirdly fixed.

B. how can tell if current firmware has this issue

  1. in the navigation page, the tile appears one by one like having animations
  2. in the home page, the time text field flashing when ticking seconds
  3. in microphone and recon apps (because these two have many widgets so more obvious), the widgets appears one by one slowly.

C. what we currently found

1.

Seems not related to whether external apps and standalone apps exist or not

2.

make clean or ninja clean, then build won't make differences, but for test, better clean before building

D. related talk:

https://discord.com/channels/719669764804444213/1301516615212470343

E. discover log

1.

firstly found after #2302 were merged, AKA 8d1fb7cb66e5fae2e6d39ae06e0df38a669cf8b1 , fixed by workaround in #2307

2.

appeared again in the halfway of work in #2331 but fixed in same PR by use bool instead of return

3.

appeared again in the halfway of work in #2333 but also fixed in same PR by use bool instead of return