portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.05k stars 519 forks source link

Microphone --->Tx #348

Closed KB6mcc closed 2 years ago

KB6mcc commented 3 years ago

Describe the bug CTCSS or any other tones and Roger beep are not working with the Microphone application.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Microphone and apply the CTCSS tone and enable roger beep'
  2. Tap on 'TX'
  3. Listen on other radio or with RF spectrum analyzer.

Expected behavior No roger beep or ctcss tone detected on other receiver.

Affected versions Please write any difference related with the Expected behavior, on the following versions:

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/98090802-microphone-tx?utm_campaign=plugin&utm_content=tracker%2F182166508&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F182166508&utm_medium=issues&utm_source=github).
eried commented 3 years ago

I am not sure if the roger beep is included in the files on the SD card, but I guess they are not. Just to confirm, it was the same SD card for your test in 1.3.1, right?

KB6mcc commented 3 years ago

I reformat the SD an updated with the new released V1.4.0 SD files before I flash with the V1.40 FW

deano817 commented 3 years ago

Same issue here on all 4 of my portapacks.

eried commented 3 years ago

Thanks, I'll take a look over the weekend. Maybe @aldude999 has some insights, since he added few options?

aldude999 commented 3 years ago

The new code sends audio_buffer from proc_mictx.cpp to the dsp_modulate.cpp functions directly, which means the code in proc_mictx.cpp for the tone generation is skipped since they output to the variable "sample". It might be possible to run the beep generation code before executing the modulation, and change the modulate functions to accept a sample instead of a buffer. This would let you modify the audio input before it gets to the modulation side and insert tones. I wouldn't expect it to be much less efficient than the way it's done now.

backtopyramidone commented 3 years ago

I just wanted to add that the ctcss implementation on soundboard is working as expected, not on mic though.

teixeluis commented 3 years ago

I can also reproduce the absence of roger beep. I do notice however that the TX stays on a bit longer when roger beep is set.

ArjanOnwezen commented 2 years ago

Duplicate of the more active #495