portapps / brave-portable

🚀 Brave web browser portable for Windows
https://portapps.io/app/brave-portable/
MIT License
315 stars 38 forks source link

Main Configuration File Problem: brave-portable.yml #106

Closed STSMHQ closed 2 years ago

STSMHQ commented 2 years ago

Behaviour

Steps to reproduce this issue

  1. Run the brave portable app for the first time.
  2. Rename the main configuration file to brave-portable.yml
  3. Run the brave portable app again.

Expected behaviour

The changed configurations in the YAML file should be considered.

Actual behaviour

The changed configurations in the YAML file aren't considered.

Configuration

App release / arch (ex. 1.0.0-2 win64) : brave-portable-win64-1.34.80-80.

Operating system (ex. Windows 10 Pro 64 bits) : Windows 11 Pro 64 bits.

Winver screenshot :

Open a command prompt and type winver then take / save the screenshot of the window and drag the image file in this issue. For example: http://bit.ly/2vA5sxR

Screenshots

My brave-portable.yml file:

image

Logs

The important stuff from the logs:

Mon, 02 May 2022 11:33:33 BST INF C:/Users/runneradmin/go/pkg/mod/github.com/portapps/portapps/v3@v3.4.0/portapps.go:127 > Configuration:
common:
  disable_log: false
  args: []
  env: {}
  app_path: ""
app:
  cleanup: true
  disable_telemetry: true
  multiple_instances: true
  profile: default

The logs show that the configuration that I've is considered, but I can't open multiple instances of brave and the cleanup doesn't work, cause when I open the brave the next time.. things from the previous session are still there.

STSMHQ commented 2 years ago

When I try the same configuration in the Phyrox (Portapps Firefox), this error occurs. So, I can't run multiple instances of any of these two browsers.

Screenshots

image

crazy-max commented 2 years ago

There is no multiple_instances opt in brave portapp: https://portapps.io/app/brave-portable/#configuration

STSMHQ commented 2 years ago

There is no multiple_instances opt in brave portapp: https://portapps.io/app/brave-portable/#configuration

@crazy-max Thanks for the answer. Are u able to implement it, please?! It would be great to have such feature. Run multiple isolated instances of the same app is the top-level of a portable app, I think.