portapps / discord-portable

🚀 Discord portable for Windows
https://portapps.io/app/discord-portable/
MIT License
229 stars 16 forks source link

discord 1.0.9020 #111

Closed wharlox closed 11 months ago

wharlox commented 11 months ago

im not sure if the assets/assets.go gets created via git-actions ; (but to be frank im 1/2 asleep and missed the merge request targeting to here vs my own fork)

edit: well the build i ran in my fork seems to be pretty stable currently (not crash-looping); i presume it'll build here eventually - or i need to edit more items.

thanks for the awesome git-actions and all the behind-the-scenes magic i dont quite understand yet

edit2:

edit3: fixes https://github.com/portapps/discord-portable/issues/110 (forgot to mention this initially)

kossnikita commented 11 months ago

Works good for me! Thanks!

lawayne commented 11 months ago

how can I get your version of the build? are you able to distribute a release or must we build it ourselves? if the latter, where can I read up on how to build your version of the app? I'm afraid I'm unfamiliar with the process 😬

kossnikita commented 11 months ago

It can be accessed in Actions Artifacts Please do not take this as an official release. Do not report bugs in this version to this repository.

lawayne commented 11 months ago

thanks a bunch! not another peep from me in these parts, chief 🤐

wharlox commented 11 months ago

fyi i updated the build with that assets/assets.go file included (not sure of its significance to be quite honest); i deleted the first build @kossnikita linked to; and yes, do not take it as an official release - we'll wait for the maintainer to handle that.

can be tested from (note this zip file contains all release types - im testing the 7z and seems stable/normal): https://github.com/wharlox/_f_portapps__discord-portable/actions -> then click on one of the runs and it will be listed under the artifacts as portapps__discord-portable; i wont link to it directly in case i add yet another change

also edited my first comment (https://github.com/portapps/discord-portable/pull/111#issuecomment-1780589358) with a few cmds to test that hex-blob

STSMHQ commented 11 months ago

@wharlox Thank you (a lot) for your efforts. I'm currently using your version. Have a nice week!

jbrazio commented 11 months ago

Is this project even maintained ? Scoop uses this portable app to distribute the Discord client.

dystopia2017 commented 11 months ago

Thank you very much, your fix works great :)

crazy-max commented 11 months ago

Sorry for the delay, made some changes to update to 1.0.9022 in #112 @wharlox Update instructions in build properties are a bit confusing. Reloading assets is not necessary actually.

wharlox commented 11 months ago

@wharlox Update instructions in build properties are a bit confusing. Reloading assets is not necessary actually.

ah cool good to know for next time; was a fun little exercise nonetheless; appreciate the whole automated workflow setup here