Closed wharlox closed 11 months ago
Works good for me! Thanks!
how can I get your version of the build? are you able to distribute a release or must we build it ourselves? if the latter, where can I read up on how to build your version of the app? I'm afraid I'm unfamiliar with the process 😬
It can be accessed in Actions Artifacts Please do not take this as an official release. Do not report bugs in this version to this repository.
thanks a bunch! not another peep from me in these parts, chief 🤐
fyi i updated the build with that assets/assets.go
file included (not sure of its significance to be quite honest); i deleted the first build @kossnikita linked to; and yes, do not take it as an official release - we'll wait for the maintainer to handle that.
can be tested from (note this zip file contains all release types - im testing the 7z and seems stable/normal):
https://github.com/wharlox/_f_portapps__discord-portable/actions -> then click on one of the runs and it will be listed under the artifacts as portapps__discord-portable
; i wont link to it directly in case i add yet another change
also edited my first comment (https://github.com/portapps/discord-portable/pull/111#issuecomment-1780589358) with a few cmds to test that hex-blob
@wharlox Thank you (a lot) for your efforts. I'm currently using your version. Have a nice week!
Is this project even maintained ? Scoop uses this portable app to distribute the Discord client.
Thank you very much, your fix works great :)
Sorry for the delay, made some changes to update to 1.0.9022 in #112 @wharlox Update instructions in build properties are a bit confusing. Reloading assets is not necessary actually.
@wharlox Update instructions in build properties are a bit confusing. Reloading assets is not necessary actually.
ah cool good to know for next time; was a fun little exercise nonetheless; appreciate the whole automated workflow setup here
im not sure if the
assets/assets.go
gets created via git-actions ; (but to be frank im 1/2 asleep and missed the merge request targeting to here vs my own fork)edit: well the build i ran in my fork seems to be pretty stable currently (not crash-looping); i presume it'll build here eventually - or i need to edit more items.
thanks for the awesome git-actions and all the behind-the-scenes magic i dont quite understand yet
edit2:
assets/assets.go
changego-bindata
but i did not go into reading about all of that_pinned_updateJson
( the text within double-quotes:\xCC....\xCC
) to a sh-file (or directly into your shell: likefoo='\xCC....\xCC'
; thenprintf "${foo}" > pinned_update.json.gzip
gzip -c res/pinned_update.json | xxd -p | tr -d '\n' | sed -r 's/(.{2})/\\x\1/g'
diff
- note that the json came from the comment at https://github.com/portapps/discord-portable/blob/master/build.properties#L13edit3: fixes https://github.com/portapps/discord-portable/issues/110 (forgot to mention this initially)