search

portapps / discord-portable

🚀 Discord portable for Windows
https://portapps.io/app/discord-portable/
MIT License
231 stars 16 forks source link

portable discord no longer respects single instance - launches a new instance on each invocation #91

Open fluffynuts opened 2 years ago

fluffynuts commented 2 years ago

Behaviour

Steps to reproduce this issue

  1. download and unpack https://github.com/portapps/discord-portable/releases/download/1.0.9004-11/discord-portable-win32-1.0.9004-11.7z
  2. run discord-portable.exe, get the app fully up (logged in, etc)
  3. run discord-portable.exe again - observe a second instance launching (and I get prompted to log in again)

If I shut both instances down and start discord-portable.exe again, discord starts up fine (logged in), so it's not a credentials issue, as far as I can see. The issue is equally reproducable by running discord.exe within the app folder

Expected behaviour

Re-invoking discord should raise an existing instance, not create a new one

I'm raising this issue linked to https://github.com/ScoopInstaller/Extras/issues/8383 wherein the scoop installer has switched to the portable apps version, breaking hotkeys to raise discord.

Actual behaviour

A new instance is created each time discord-portable or app-*/discord.exe is invoked

Configuration

1.0.9004-11 / win11 / 64bit

Winver screenshot : image

Screenshots

If applicable, add screenshots to help explain your problem.

Logs

Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:118 > --------
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:119 > Operating System: Windows 10.0.22000
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:120 > Starting Discord 1.0.9004-11 (portapps 3.4.0)...
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:121 > Release date: 2022/03/06 22:03:37
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:122 > Publisher: CrazyMax (https://github.com/portapps/discord-portable)
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:123 > Root path: C:\tmp\discord
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:127 > Configuration:
common:
  disable_log: false
  args: []
  env: {}
  app_path: ""
app:
  cleanup: false

Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:168 > Process: C:\tmp\discord\app\app-1.0.9004\Discord.exe
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:169 > Args (config file): 
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:170 > Args (cmd line): 
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:171 > Args (hardcoded): --user-data-dir=C:\tmp\discord\data
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:172 > Working dir: C:\tmp\discord\app\app-1.0.9004
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:173 > App path: C:\tmp\discord\app
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:174 > Data path: C:\tmp\discord\data
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:175 > Previous path: 
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:181 > Launching Discord
Tue, 26 Apr 2022 16:04:03 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:191 > Exec C:\tmp\discord\app\app-1.0.9004\Discord.exe --user-data-dir=C:\tmp\discord\data

Discord 1.0.9004
Starting app.
Starting updater.
Module ./ElectronTestRpc was not included.
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:118 > --------
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:119 > Operating System: Windows 10.0.22000
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:120 > Starting Discord 1.0.9004-11 (portapps 3.4.0)...
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:121 > Release date: 2022/03/06 22:03:37
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:122 > Publisher: CrazyMax (https://github.com/portapps/discord-portable)
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:123 > Root path: C:\tmp\discord
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:127 > Configuration:
common:
  disable_log: false
  args: []
  env: {}
  app_path: ""
app:
  cleanup: false

Tue, 26 Apr 2022 16:04:56 SAST INF D:/a/discord-portable/discord-portable/main.go:77 > Update settings...
Tue, 26 Apr 2022 16:04:56 SAST INF D:/a/discord-portable/discord-portable/main.go:84 > Current settings settings={"BACKGROUND_COLOR":"#202225","SKIP_HOST_UPDATE":true,"USE_PINNED_UPDATE_MANIFEST":true}
Tue, 26 Apr 2022 16:04:56 SAST INF D:/a/discord-portable/discord-portable/main.go:88 > New settings settings={"BACKGROUND_COLOR":"#202225","SKIP_HOST_UPDATE":true,"USE_PINNED_UPDATE_MANIFEST":true}
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:168 > Process: C:\tmp\discord\app\app-1.0.9004\Discord.exe
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:169 > Args (config file): 
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:170 > Args (cmd line): 
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:171 > Args (hardcoded): --user-data-dir=C:\tmp\discord\data
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:172 > Working dir: C:\tmp\discord\app\app-1.0.9004
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:173 > App path: C:\tmp\discord\app
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:174 > Data path: C:\tmp\discord\data
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:175 > Previous path: 
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:181 > Launching Discord
Tue, 26 Apr 2022 16:04:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:191 > Exec C:\tmp\discord\app\app-1.0.9004\Discord.exe --user-data-dir=C:\tmp\discord\data

Discord 1.0.9004
Starting app.
Starting updater.
Module ./ElectronTestRpc was not included.
Tue, 26 Apr 2022 16:05:25 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:212 > Closing Discord
Not saving settings, it has been externally modified.
Tue, 26 Apr 2022 16:05:27 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:212 > Closing Discord
Tue, 26 Apr 2022 16:05:27 SAST ERR D:/a/discord-portable/discord-portable/main.go:148 > Cannot remove shortcut error="remove C:\\Users\\davyd.mccoll\\AppData\\Roaming\\Microsoft\\Windows\\Start Menu\\Programs/Discord Portable.lnk: The system cannot find the file specified."
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:118 > --------
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:119 > Operating System: Windows 10.0.22000
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:120 > Starting Discord 1.0.9004-11 (portapps 3.4.0)...
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:121 > Release date: 2022/03/06 22:03:37
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:122 > Publisher: CrazyMax (https://github.com/portapps/discord-portable)
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:123 > Root path: C:\tmp\discord
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:127 > Configuration:
common:
  disable_log: false
  args: []
  env: {}
  app_path: ""
app:
  cleanup: false

Tue, 26 Apr 2022 16:05:28 SAST INF D:/a/discord-portable/discord-portable/main.go:77 > Update settings...
Tue, 26 Apr 2022 16:05:28 SAST INF D:/a/discord-portable/discord-portable/main.go:84 > Current settings settings={"BACKGROUND_COLOR":"#202225","IS_MAXIMIZED":false,"IS_MINIMIZED":false,"SKIP_HOST_UPDATE":true,"USE_PINNED_UPDATE_MANIFEST":true,"WINDOW_BOUNDS":{"height":720,"width":1280,"x":320,"y":156}}
Tue, 26 Apr 2022 16:05:28 SAST INF D:/a/discord-portable/discord-portable/main.go:88 > New settings settings={"BACKGROUND_COLOR":"#202225","IS_MAXIMIZED":false,"IS_MINIMIZED":false,"SKIP_HOST_UPDATE":true,"USE_PINNED_UPDATE_MANIFEST":true,"WINDOW_BOUNDS":{"height":720,"width":1280,"x":320,"y":156}}
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:168 > Process: C:\tmp\discord\app\app-1.0.9004\Discord.exe
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:169 > Args (config file): 
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:170 > Args (cmd line): 
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:171 > Args (hardcoded): --user-data-dir=C:\tmp\discord\data
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:172 > Working dir: C:\tmp\discord\app\app-1.0.9004
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:173 > App path: C:\tmp\discord\app
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:174 > Data path: C:\tmp\discord\data
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:175 > Previous path: C:\tmp\discord
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:181 > Launching Discord
Tue, 26 Apr 2022 16:05:28 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:191 > Exec C:\tmp\discord\app\app-1.0.9004\Discord.exe --user-data-dir=C:\tmp\discord\data

Discord 1.0.9004
Starting app.
Starting updater.
Module ./ElectronTestRpc was not included.
Tue, 26 Apr 2022 16:05:56 SAST INF ..\..\Users\runneradmin\go\pkg\mod\github.com\portapps\portapps\v3@v3.4.0\portapps.go:212 > Closing Discord
Not-a-Tyler commented 1 year ago

Would be nice if this were fixed or a solution were found, currently the only reason I'm using regular discord