portapps / handbrake-portable

🚀 HandBrake portable for Windows
https://portapps.io/app/handbrake-portable/
MIT License
15 stars 2 forks source link

Handbrake "portable" is NOT really portable #34

Open pgScorpio opened 1 year ago

pgScorpio commented 1 year ago

Behaviour

The "portable" version of handbrake needs windowsdesktop-runtime to be installed, but, since one important use of portable software is to run the program on a computer where you don't have any installation rights, a real "portable" version should never need additional software to be installed.

Steps to reproduce this issue

  1. expand HandBrake-1.6.1-x86_64-Win_GUI.zip to a USB stick
  2. run HandBrake.exe on the USB stick on a computer which doesn't have windowsdesktop-runtime installed yet.
  3. you will be prompted to install windowsdesktop-runtime!
  4. if you don't have any installation rights on that computer the installation of windowsdesktop-runtime will fail, so Handbrake can't be run.

Expected behaviour

Tell me what should happen The portable program should run, no mather what software is installed or not on that computer.

Actual behaviour

Tell me what happens instead See "Steps to reproduce"

Configuration

App release / arch (ex. 1.0.0-2 win64) :

Operating system (ex. Windows 10 Pro 64 bits) : Windows 10 Pro Version 10.0.19044

Winver screenshot :

Open a command prompt and type winver then take / save the screenshot of the window and drag the image file in this issue. For example: http://bit.ly/2vA5sxR

Version 21H2 (OS Build 1904.2486)

Screenshots

If applicable, add screenshots to help explain your problem.

Logs

Join the log file log\[appname]-portable.log to this issue.

crazy-max commented 6 months ago

Any desktop app that uses .NET Core like HandBrake requires the .NET Core Desktop Runtime to be installed. This is pretty much similar to VCRedist for other applications.

Feel free to open a PR to enhance the documentation at https://github.com/portapps/portapps.github.io/blob/dev/src/_includes/app/infos/handbrake.md