search

porter-finance / v1-core

⛰️ Smart contracts powering the Porter protocol.
https://porter.finance
GNU Affero General Public License v3.0
4 stars 3 forks source link

pass in number of tokens to withdraw #245

Closed RusseII closed 2 years ago

RusseII commented 2 years ago
image

This change is to support the withdraw panel. Previously it was only possible to withdraw 100% of the available collateral.

This method will also be called in the future for refinancing.

RusseII commented 2 years ago

Should we move "withdrawExcessPayment" under pay?

Yeah ... we can probably reorder a few of the methods

Namaskar-1F64F commented 2 years ago

Should we move "withdrawExcessPayment" under pay?

Yeah ... we can probably reorder a few of the methods

If you end up doing this - keep the style guide in mind for function grouping 👍 https://docs.soliditylang.org/en/v0.8.13/style-guide.html#order-of-functions