Where it makes sense, the bondHolder signer should be used instead of the issuer. By default the issuer signs transactions within the test. .connect(bondHolder) uses the bond holder's address to perform actions. To get this to work in most places, the issuer must transfer tokens to the bond holder and then the bond holder can perform the actions.
In addition to this, I found a bug in the expecting token balance changes. Because there was no await on the function, the tests were false positives. This uncovered a problem with how we were handling decimals in the test config max supply (18 decimals for all of them).
These configs are now also dynamically made in the fixture.
Where it makes sense, the
bondHoldersigner should be used instead of theissuer. By default theissuersigns transactions within the test..connect(bondHolder)uses the bond holder's address to perform actions. To get this to work in most places, theissuermusttransfertokens to the bond holder and then the bond holder can perform the actions.In addition to this, I found a bug in the expecting token balance changes. Because there was no
awaiton the function, the tests were false positives. This uncovered a problem with how we were handling decimals in the test config max supply (18 decimals for all of them).These configs are now also dynamically made in the fixture.
closes #294