portermichael / portfolio

This is a portfolio project made to showcase blog posts and github work. I'm currently building a jekyll blog to replace this.
https://mike-porter-portfolio.herokuapp.com/
0 stars 0 forks source link

Styling suggestion #6

Closed musflood closed 7 years ago

musflood commented 7 years ago

Try making the green bar at the top go all the way to the edges and/or have an image for the background.

@media screen and (min-width: 600px){

  body {
    max-width: 960px;
  }
...

instead of setting body, try setting main

musflood commented 7 years ago

Maybe also try adding some transition animations so stuff doesn't jump around as much. For example, using slideUp/Down instead of hide and show:

viewArticles.shortenText = function () {
  $('.article-body *:nth-of-type(n+2)').hide();
  $('#articles').on('click', '.read-more', function(event){
    event.preventDefault();
    if($(this).html() === 'Read more →') {
      $(this).prev().children().show(); // here: slideDown
      $(this).html('Read less ←');
      $(this).blur();
    } else if ($(this).html() === 'Read less ←') {
      $('.article-body *:nth-of-type(n+2)').hide(); // here slideUp
      $(this).html('Read more →');
      $(this).blur();
    }
  });
};
portermichael commented 7 years ago

Thanks for demonstrating slidedown and slideup!