portfolio-performance / portfolio-help

Manual for Portfolio Performance
https://help.portfolio-performance.info/en
18 stars 20 forks source link

Base Documentation on Program Sample File #30

Open flywire opened 6 months ago

flywire commented 6 months ago

PP comes with sample files for user testing and it would be useful if the use could also test the documentation file.

Options:

  1. Use an existing sample file
  2. Modify and use and existing sample file
  3. Add documentation file to program samples
hug-sch commented 5 months ago

There could be much improvement in my currently used example files. When I began working on the docs, I reviewed both existing sample files, but encountered some issues. The DAX sample file is heavily focused on Germany, featuring only purchase transactions and one deposit, all from 2018. The Kommer file is more recent and includes more types of transactions, but they are all related to ETFs. I'm struggling with the decision between using a sample file that is easy to comprehend and useful for demonstrating various concepts (such as in my recent chapter on stock splits) and one that provides real-world context. Initially, I was also hesitant to utilize an existing company's data, hence the placeholders like "share-1" and "broker-A."

Also, for the sake of maintenance, such as updating screenshots, it would be preferable to consistently use the same small set of sample files. Maybe, we should decide and agree upon which one (or two/three) we should use. Any suggestions? It’s a good idea to add them to the program samples.

buchen commented 5 months ago

First, I agree that the DAX sample is outdated. We should deleted. I created it back then to demo an industry classification and it was easiest to create this for the DAX.

About the Sommer sample file. I made some changes this week: I added a couple more dividend statements, I added a Bitcoin holding, and I fixed some translations problems.

But I am thinking:

The sample is part of the repository as XML: https://github.com/portfolio-performance/portfolio/blob/master/name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/parts/kommer.xml

The translation works likes this:

Personally, I update the sample like this:

My gut feeling is: unless we have a complex different example, I would rather enhance the existing demo file.

hug-sch commented 5 months ago

From a documentation perspective, I would recommend the following modifications to the kommer.xml file:

flywire commented 5 months ago

I don't think demo, implying a fully contained example, is the right term. I particularly like the ability to use a sample file and either save it with a new name or regenerate fresh test data. A sample file can still be used for demonstrations in the manual and forum.

hug-sch commented 5 months ago

Yes, you're right. sample.xml or sample-portfolio.xml better suits the content and it can be used in the manual.

Do you have any suggestions regarding the content?

flywire commented 5 months ago

I like the suggestions above but data will be required for other functionality. Start there and expand/consolidate data as required.

hug-sch commented 4 months ago

The text Reconstruct sample-portfolio.md contains the beginning of a proposal for the extension and updating of the kommer.xml file.

Any corrections and suggestions are welcome.

Sn1kk3r5 commented 2 months ago

@buchen

My gut feeling is: unless we have a complex different example, I would rather enhance the existing demo file.

Are you fine, if I try to add to following stuff?

In case I'am able to perform this, I would then create the corresponding bookings. If it's fine for you. Cheers

hug-sch commented 1 month ago

@buchen Hi Andreas,

@Sn1kk3r5 has finished the updating of the kommer.xml. As already discussed above, it seems better to rename the file; for example sample.xml or demo.xml. Is that OK with you?

flywire commented 3 weeks ago

RE https://github.com/portfolio-performance/portfolio/pull/4022 & 7fa0b70 There is no account transfer. Instead of a deposit into Foreign Currency Accounts GBP could it be established with a transfer of 200EUR from the Deposit Account?

Sn1kk3r5 commented 3 weeks ago

@flywire

I'll take a note and will bring it with the next PR. For the time being a manual booking should do it :-) Highest attention was the alignment between English and German in order to make capturing screenshots way easier.

Cheers