search

portfolio-performance / portfolio

Track and evaluate the performance of your investment portfolio across stocks, cryptocurrencies, and other assets.
http://www.portfolio-performance.info
Eclipse Public License 1.0
2.86k stars 589 forks source link

GICS taxonomy not up-to-date #1679

Open Alain-CYS opened 4 years ago

Alain-CYS commented 4 years ago

Hi,

The GICS taxonomy in Portfolio Performance seems not up-to-date, at least for the "communication services" sector which seems to have evolved from "telecommunication services".

I didn't check the other sectors.

In Portfolio Performance: image

According to MSCI (january 2020) https://www.msci.com/documents/1296102/11185224/GICS+Methodology+2020.pdf: image

According to S&P (2018) https://www.spglobal.com/marketintelligence/en/documents/112727-gics-mapbook_2018_v3_letter_digitalspreads.pdf: image

Regards, Alain

ghost commented 4 years ago

Hi, maybe you would like to to create a pull request yourself? The categories are just defined within text files located at https://github.com/buchen/portfolio/blob/78ee88c0fd8a40bc825cd4208745ee7c3bfa4176/name.abuchen.portfolio/META-INF/taxonomy/industry-gics.properties and https://github.com/buchen/portfolio/blob/78ee88c0fd8a40bc825cd4208745ee7c3bfa4176/name.abuchen.portfolio/META-INF/taxonomy/industry-gics_de.properties.

Alain-CYS commented 4 years ago

Not sure how this is working (my first attempt at pull-request), but I made a pull-request : https://github.com/buchen/portfolio/pull/1695.

pfalcon commented 1 year ago

@Nirus2000, @buchen: Perhaps this issue should be closed as implemented?