portfolio-performance / portfolio

Track and evaluate the performance of your investment portfolio across stocks, cryptocurrencies, and other assets.
http://www.portfolio-performance.info
Eclipse Public License 1.0
2.94k stars 606 forks source link

Input required for 'SubTotal' / Eingabe fehlt für Wert 'Zwischensumme' #2094

Open Steinblock opened 3 years ago

Steinblock commented 3 years ago

Describe the bug

I transfered a crypto currency (Litecoin / LTC) from an exchange to a wallet.

Because this requires a fee (0.0000042 LTC) I created a Delivery (outbound)

Usually this works (i.e. for BTC / ETH with higher fees) but in that case I noticed that the quote field was empty.

I thought I accidentially set the value to zero and wanted to edit the record but this is not possible anymore.

To Reproduce

image

image

image

Expected behavior

Even if the amount is so low that the price is basically zero (0,0009156 EUR) I should still be able to edit the record.

Desktop:

metal450 commented 3 years ago

I posted a similar issue (allow $0 transactions), but for a different use case. Closed my duplicate report, but here was my description:


There seems to be a check in the software preventing any sale where the amount totals $0 (it shows the error "Input required for 'Total'). In the case of cryptocurrency, it would be much more convenient if this were allowed. Why? In PP, fees are always paid out in 'currency,' not in 'securities' - but in crypto, fees are paid in the crypto itself (i.e. ethereum gas). To document this in PP, it takes 2 transactions each time: a Sell transaction to convert the crypto to USD, followed by a Fees transaction for the same amount. However, if "Sell" transactions weren't prevented from having a total of $0, this could be documented as just one "Sell" where the amount equals the fees. i.e. in the Sell dialog, the amount is $10, fees is $10, thus credit total is $0. The result is the as desired: the crypto 'shares' were removed, you booked $10 in fees, and no change to your USD holdings - but it took half as many transactions.

As my transaction history grows increasingly cluttered with Sell, Fee, Sell, Fee, Sell, Fee, I think it'd be a lot more crypto-friendly to just remove this 'total can't be $0' requirement.

Kansai53 commented 3 years ago

I also have this problem, is there a reason it cant let you sell for $0? I always sell for 0.01, then put a small 'reconciliation' transaction to get rid of the extra cents every few months. But it would be much easier if it just wouldn't force you to sell for a nonzero amount.

chirlu commented 3 years ago

is there a reason it cant let you sell for $0?

Yes: The proper transaction type for a “sell” that doesn’t result in money on an account is outbound delivery.

The issue described here by @Steinblock is different.

metal450 commented 3 years ago

The issue described here by @Steinblock is different.

I only posted it here because I was explicitly told this was a duplicate (when I made a separate issue, https://github.com/buchen/portfolio/issues/2103)

Yes: The proper transaction type for a “sell” that doesn’t result in money on an account is outbound delivery.

Then perhaps for UI clarity, it would be better to display that info on the dialog - i.e. "Sell with an amount of $0 should be input as Outbound Delivery," vs "Input required for sub-total."

chirlu commented 3 years ago

This issue is actually one that was already mentioned in #2005 (an importer issue) – see in particular https://github.com/buchen/portfolio/issues/2005#issuecomment-766863936 for an analysis.

myrdd commented 2 years ago

My current workaround: First put 0.01 (or any other non-zero value) into the SubTotal field, then put 0 (zero) into the Quote field. After that, don't click into the SubTotal field anymore. Press Save. Works on v0.56.3