search

portier / portier.github.io

Website for Portier, an email-based, passwordless authentication that you can host yourself.
https://portier.github.io
362 stars 18 forks source link

RPs: Signature checking #10

Closed onli closed 8 years ago

onli commented 8 years ago

Both our current RPs, the python example and the sinatra module, do not verify the signature. In the case of the sinatra module that is because the check is throwing a error in the used jwt module (see here, verify is called on a string, which does not have such a function), and help would be great to get this cleared up.

djc commented 8 years ago

Actually, the Python demo-rp has a PR that implements signature verification:

https://github.com/letsauth/demo-rp/pull/1

onli commented 8 years ago

I opened an issue for the JWT gem: https://github.com/nov/json-jwt/issues/32

onli commented 8 years ago

https://github.com/onli/sinatra-browserid/commit/b38227002824ad7f84b3b47a8324e212e0991ee6 fixes it for the sinatra browserid gem. I'll close here, since now both existing RPs have it.

djc commented 8 years ago

Well, @callahad hasn't merged the demo-rp PR yet.