search

portier / portier.github.io

Website for Portier, an email-based, passwordless authentication that you can host yourself.
https://portier.github.io
364 stars 18 forks source link

First draft of the protocol specification, client-side #33

Closed stephank closed 6 years ago

stephank commented 6 years ago

💪

onli commented 6 years ago

I wonder whether we should have a summary section at the top which shows the properties on play here. Something like: The broker has a public key here, the RP calls the broker with those params, the broker calls the IdP with the same(?) params, the RP end up with a jwt/json object with those exact fields. Might be too long, but maybe helpful?

onli commented 6 years ago

Seems pretty on point otherwise, and I saw no issues. Still, maybe @skorokithakis would like to have a look at this as well?

stephank commented 6 years ago

I tried to address the points you highlighted, without going through the whole rearranging of schema sections just yet: https://github.com/portier/portier.github.io/compare/5b34b28...571221f

Hopefully this helps clarify things more? I figure we should leave the bigger changes for when we actually get around to them, and have more time to review those separately.

But please do (re)raise any concerns if it's no good!

onli commented 6 years ago

Yes, I think this helps. I'd like to have more eyes on it, but I also don't want to block it. You should merge this :)