search

portive / wysimark

The Wysiwyg Editor for Markdown: 100% CommonMark + GFM with Uploads and Image Resizing
Other
239 stars 41 forks source link

Bug in Safari: Invalid regular expression: invalid group specifier name #25

Closed ENT108 closed 1 year ago

ENT108 commented 1 year ago

Description The package won't run in Safari.

Reproduction Screenshot 2023-06-14 at 23 44 30

Steps To reproduce the behavior:

  1. Add Wysimark to your React app
  2. Build your app
  3. Run it
  4. See error in the console

Expectation React app with Wysimark starts.

Environment

thesunny commented 1 year ago

Thanks @ENT108

Nice catch.

It appears Safari doesn't support negative look behinds. I'll have to find another way to write this. Thanks.

ENT108 commented 1 year ago

Any chance for a fix? Or a workaround?

thesunny commented 1 year ago

I'll try to have a fix out today.

ENT108 commented 1 year ago

I'll try to have a fix out today.

I would love to stay with this package as there is no real 1 to 1 alternative. But I need Safari and React 18. Glad to hear that!

thesunny commented 1 year ago

@ENT108 I put out a temporary fix just now. It disables auto format for italics but works fine in Safari.

Use version 2.2.19

thesunny commented 1 year ago

@ENT108

I fixed this properly now without disabling auto format.

Fixed in version 2.2.20

thesunny commented 1 year ago

@ENT108

FYI I sent you an email asking for a chat about Wysimark. Just realized I forgot to mention Wysimark in the title of the email.

No pressure but didn't want you to think it was spam.

ENT108 commented 1 year ago

@ENT108

I fixed this properly now without disabling auto format.

Fixed in version 2.2.20

Tested! Thanks a million! 🤘🏻