search

portive / wysimark

The Wysiwyg Editor for Markdown: 100% CommonMark + GFM with Uploads and Image Resizing
Other
239 stars 41 forks source link

height & minHeight properties are not working #27

Closed MuhammadSalmanSiddiqui closed 1 year ago

MuhammadSalmanSiddiqui commented 1 year ago

Height and MinHeight Properties are not working.

Screenshot 2023-06-20 at 5 52 13 PM
thesunny commented 1 year ago

@MuhammadSalmanSiddiqui

Thank you for the bug reports.

In the future, can you use the bug reporting forms that appear when you click the "New Issue" button? There is a form for a bug report that will be an option. Click "Get Started" next to it.

image

I recognize that it takes a longer to file the issue, and that it can be a pain, but it can be challenging and time consuming to figure out what went wrong without a clear explanation of what was expected.

For example, I don't know if this is throwing an error in the editor and if so when it appears. It's unclear what is happening for you to think it's not working. This bug might be obvious when I dive into it, but given the previous bug we had to diagnose, it was not obvious and it took a lot of back and forth that could probably have been avoided. Actually, I created the bug report forms in response to the amount of back and forth that was required in our previous issue.

This helps reduce the time it takes to resolve each bug and allows for more time to work on other issues and to improve the software overall.

I'm happy to work on these issue and really do appreciate the feedback.

Please provide some further details on this bug. Thanks.

MuhammadSalmanSiddiqui commented 1 year ago

Hey @thesunny , As you can see, I gave the editor a height of 900, but the editor's height stays the same as before.

![Uploading Screenshot 2023-06-21 at 4.11.03 AM.png…]()

Screenshot 2023-06-20 at 5 52 13 PM
MuhammadSalmanSiddiqui commented 1 year ago
Screenshot 2023-06-21 at 4 11 03 AM
MuhammadSalmanSiddiqui commented 1 year ago

@thesunny any updates on this issue?

thesunny commented 1 year ago

@MuhammadSalmanSiddiqui 

It is working for me. There likely is something different in how it is being implemented.

First, can you check the HTML to see if it is emitting the min-height/max-height for the editor box? Should look something like this on the highlighted line. See there is a min-height and max-height?

Also, could you

thesunny commented 1 year ago

Another thing to check is to see if it is in another HTML element that is constraining its height.

MuhammadSalmanSiddiqui commented 1 year ago

My fault, I used a string format and it only works with integers.