Feat/sign2 - Githubissues

dupuchba commented 6 years ago

Signing a request with the v2 protocol Working BUT Version is hardcoded and query protocol generation has not been done yet so it's not tested on all services

dupuchba commented 6 years ago

I'll do all the change this weekend as I am working on this project saturday & sunday, really excited to see if I can generate some query requests ^^

dupuchba commented 6 years ago

You will find my new commit concerning generating namespaces for the query protocol.

Where am I :

OK for Amazon SimpleDB with signing v2
I have to try for the other domains

What is left :

Figuring out how to use the move parameters (used for 3/4 functions in the query protocol
Output coercion : it’s XML right now
Passing the version date information to other namespace (not AWS SimpleDB)
Generating the right payload for Attributes.Name.x =

Points where I am not confortable yet

gen-operation & gen-operation-query use a lot of the same code, that’s not viable
I had to reload manually all middleware in sync-http-client in order to fully signv2 the request because wrap-sign was call last, with body already coerced
globally I think we can reduce my code greatly

Next steps :

correct comments on this PR
Do the what’s left and repeat :D

/cc @cgrand @viesti

dupuchba commented 6 years ago

Added test for signing v4 from amazon as there are some corner cases not working when signing v4 with the query protocol. It is still a wip. I'll probably have to split the sign4 functions to make the test easier/pass

portkey-cloud / aws-clj-sdk

Feat/sign2 #17

Where am I :

What is left :

Points where I am not confortable yet

Next steps :