portkey-cloud / aws-clj-sdk

Clojure bindings for AWS
103 stars 12 forks source link

"json" protocol v1.0 #29

Open milt opened 6 years ago

milt commented 6 years ago

This PR begins to address #4 by adding support for "json" protocol apis, version 1.0 only. Confirmed working with DynamoDB and DDBStreams.

Other notable changes:

Smells:

cgrand commented 6 years ago

Fantastic work Milton! @dupuchba do you have time to review it since there’s overlap with your current work?

milt commented 6 years ago

@cgrand thanks, I love where this project is going! One last review note , I added two additional commits to produce slightly more useable errors (that have the spec keyword, in addition to the shape as a message), but might break downstream projects that rely on the exception map being the root of the ex-info map.

dupuchba commented 6 years ago

@milt Thanks a lot for your work !!!

I won't be able to review it today but I'll take some time tomorrow !