search

portugueslab / sashimi

Lightsheet control
GNU General Public License v3.0
1 stars 2 forks source link

Display ROI dimensions #13

Closed vilim closed 4 years ago

vilim commented 4 years ago

And offer presets (for cerebellum etc)

diegoasua commented 4 years ago

It is interesting to have the ROI dimensions on display. Good idea. However I think the presets are completely unecessary. When I said let's make the lightsheet deterministic I did not mean lets remove the human completely from the equation

vilim commented 4 years ago

Presets are useful to always have exactly the same stack dimensions for each type of experiments. they should be user-defanable of course.

diegoasua commented 4 years ago

This is not necessarily important. Fish might be of different days (dpf 6-8) and therefore of different sizes. Plus there is inter-individual variability which makes some fish biggers than others. So it can happen that the ROI that works one day for one fish does not work for another. Also I think this is some extra work that is going to benefit very few and reduced cases, not everyone will use it. Unless other experimenters express their interest in this I don't think it is worth working on it.

diegoasua commented 4 years ago

I am refering specifically to the presets. The ROI size display is actually a good idea. And I will add hiding the ROI selection tool in the display once used