portugueslab / stytra

A modular package to control stimulation and track behaviour
http://www.portugueslab.com/stytra/
GNU General Public License v3.0
41 stars 26 forks source link

Update Tests #62

Closed fedem-p closed 2 years ago

fedem-p commented 2 years ago

Migrated tests from travis to github workflows:

  1. added lint job before and reformatted most of the code (flake is commented, can be included later) 2 .there's a second job in the github workflow which, if un-commented, allows to run most of the test singularly (for debugging purposes)
  2. added test_init_gui.py to test just the initialization of the gui when calling a specific protocol
  3. test_imaging is half commented because it gets stuck after running successfully
  4. test_pytests is the only one which hasn't been tested yet

TODO:

vigji commented 2 years ago

Great work on porting the tests onto Github actions! I would suggest splitting this PR in 2 (or more parts)

1. that gets rid of Travis test infrastructure (incl. removing the yaml and the readme badge), blacks and introduces linting checks on github actions

2. adds the functional tests on github actions.

I would actually just keep black and linting on a separate PR, but only if that is not too much a headache to split by now...you think the splitting is essential @vilim ?

vilim commented 2 years ago

It is difficult to review the test code (the actual important change) because of the noise from black. Another approach would be to point the attention of reviewers through a self-review (recommended in any case)

fedem-p commented 2 years ago

Yes, sorry, I'll try to split up the pull request in 2, add some of the changes and provide a self review!