search

portugueslab / stytra

A modular package to control stimulation and track behaviour
http://www.portugueslab.com/stytra/
GNU General Public License v3.0
41 stars 26 forks source link

Optimise the Prefilter #73

Closed nvbln closed 2 years ago

nvbln commented 2 years ago

Pretty minor PR. The OpenCV threshold function should be about 2-3 times more efficient than the line that it replaces. This can especially become noticeable when not downsampling the image.

nvbln commented 2 years ago

As for the lint tests, they again seem to be completely unrelated to this PR.

vigji commented 2 years ago

Agreed, sorry, I thought master was passing everything... Annoying, but maybe better to merge this with the error and fix linking from master after the other PRs are closed. Local tests are passing?