portworx / helm

Repository for Portworx Helm assets
Apache License 2.0
48 stars 65 forks source link

PB-8576: Add excludelist for azureProxy and includeList for no proxy #661

Closed px-kesavan closed 1 month ago

px-kesavan commented 1 month ago

What this PR does / why we need it: This PR Adds support to have excludelist for azureProxy and includeList for no proxy, thus giving the flexibility to apply proxy config for individual services

Introduced helm param

  1. proxy. excludeAzureProxyList: [] - This is a list type where user can provide the service names (of deploy/sts/jobs) to avoid adding azure proxy annoation This can be do with values.yaml providing the list of service names as an array or using the set command , eg --set "proxy.excludeAzureProxyList[0]=px-backup"

  2. proxy.includeNoProxyList: [] - This is a list type where user can provide the service names (of deploy/sts/jobs) to add no_proxy env setting This can be do with values.yaml providing the list of service names as an array or using the set command , eg

--set "proxy.includeNoProxyList[0]=px-backup"

Which issue(s) this PR fixes (optional) Closes # https://purestorage.atlassian.net/browse/PB-8576

Special notes for your reviewer: Testing

Without and with excludeAzureProxyList

Screenshot From 2024-10-28 15-07-10

Without and with includeNoProxyList

Screenshot From 2024-10-28 15-08-41

Successfully added with no_proxy settings in px-backup deploy Screenshot From 2024-10-28 15-23-21

Verified there is no azure proxy annotation Screenshot From 2024-10-28 15-24-15

Used helm command : helm install px-central charts/px-central --namespace central --create-namespace --version 2.8.0 --set persistentStorage.enabled=true,persistentStorage.storageClassName="px-db",pxbackup.enabled=true,proxy.httpProxy.noProxy="127.0.0.1\,localhost","proxy.includeNoProxyList[0]=px-backup",proxy.azureProxyEnabled=true,"proxy.excludeAzureProxyList[0]=px-backup"