portworx / helm

Repository for Portworx Helm assets
Apache License 2.0
48 stars 65 forks source link

PB-8776 : Added changes to have kubernetes.azure.com/no-http-proxy-vars as false when set in excludeAzureProxyList #666

Closed px-kesavan closed 2 weeks ago

px-kesavan commented 3 weeks ago

What this PR does / why we need it: When user already added the annotation kubernetes.azure.com/no-http-proxy-vars: "true" manually in their microservices , helm upgrade should set it to false when the microservice is listed in the proxy.excludeAzureProxyList. Without this change , the annotation will persist with value "true" as helm is upgraded with merge strategy

Which issue(s) this PR fixes (optional) Closes # https://purestorage.atlassian.net/browse/PB-8776

Special notes for your reviewer:

Helm upgrade command : helm upgrade px-central stable/px-central-2.8.0.tgz --namespace px-backup --version 2.8.0 --set persistentStorage.enabled=true,persistentStorage.storageClassName="default",pxbackup.enabled=true,proxy.httpProxy.noProxy="pxcentral-keycloak-http\,.px-backup\,.svc\,.cluster.local\,pxcentral-keycloak-http\,px-backup\,px-backup-ui\,px-central-ui\,pxc-backup-mongodb-headless\,pxcentral-apiserver\,pxcentral-backend\,pxcentral-frontend\,pxcentral-keycloak-headless\,pxcentral-keycloak-postgresql\,pxcentral-keycloak-postgresql-headless\,pxcentral-lh-middleware\,pxcentral-mysql\,.portworx\,stork-service\,portworx-api\,portworx-kvdb-service\,portworx-operator-metrics\,portworx-service\,prometheus-operated\,px-csi-service\,px-prometheus\,10.100.0.1","proxy.includeNoProxyList[0]=px-backup",proxy.azureProxyEnabled=true,"proxy.excludeAzureProxyList[0]=px-backup" --timeout=120m

Screenshot From 2024-11-12 20-21-56 Screenshot From 2024-11-12 20-57-49