portworx / helm

Repository for Portworx Helm assets
Apache License 2.0
48 stars 65 forks source link

PB-8980: check for pxbackup.enabled flag for deploying alertmanager, prometheus, pre-upgrade hook #668

Closed px-kesavan closed 22 hours ago

px-kesavan commented 1 day ago

What this PR does / why we need it: check for pxbackup.enabled flag for deploying alertmanager, prometheus, pre-upgrade hook. This ensure none of the px-backup related components are not deployed when pxbackup.enabled is not true

Which issue(s) this PR fixes (optional) Closes # https://purestorage.atlassian.net/browse/PB-8980

Special notes for your reviewer:

Installed 2.8.1 without pxbackup.enabled=true

Screenshot From 2024-12-02 18-08-24

Installed 2.8.1 with pxbackup.enabled=true and upgraded without pxbackup.enabled=true

Screenshot From 2024-12-02 18-22-13

Ensured none of the px-backup components exists after install/upgrade

Note: PVC still remains as it is not handled by helm , we need to remove it manually incase of upgrade (when installed with pxbackup enabled and upgraded with disabled)