portworx / kvdb

Generic Key-Value interface
Apache License 2.0
40 stars 12 forks source link

PWX-37961: In unlock don't write to the channel #129

Closed pnookala-px closed 3 months ago

pnookala-px commented 3 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional) Closes #

Special notes for your reviewer:

sangleganesh commented 3 months ago
  1. Can we remove the comment about double unlock ?
  2. Can we unconditionally close the channel ? that way we automatically expire the locks even if CAD fails with connection issues ?