search

portworx / kvdb

Generic Key-Value interface
Apache License 2.0
40 stars 12 forks source link

Add slack notifications. Remove email. #69

Closed adityadani closed 5 years ago

adityadani commented 5 years ago

@sangleganesh There has to be some way the users of this package be notified that a build or UT is failing. Polling the travis builds and checking if it is running fine is not an ideal way. This change will only send a notification if there is a build failure. Also with this only the targeted audience will get a notifications on slack instead of a whole email alias.

Can you suggest any other way by which this can be achieved?

sangleganesh commented 5 years ago

I am not on slack. no one has complained about emails. this is trying to solve a problem which does not exists. you want slack, add one. don't remove emails.

adityadani commented 5 years ago

A lot of people are complaining about too many emails as well, which was the motivation for this change.

sangleganesh commented 5 years ago

people can enable filters. what's the problem in that ? whole eng needs to know if something is failing. they can chose to ignore it if they want.

adityadani commented 5 years ago

I am fine with that as well. I was of the opinion that people do not want emails. I have added back email notifications.

rodrigc commented 5 years ago

@sangleganesh e-mails sent to eng@portworx.com go to all of engineering, and all of test. As the headcount at Portworx goes up, this is a lot of people. By default, new hires are bombarded with e-mails from travis. New hires are not always savvy on how to set up gmail filters. At least with Slack notifications, users have the option of leaving certain slack channels, or setting Mute on a specific slack channel that they are subscribed to.

I think the latest patch in this PR that @adityadani submitted is a reasonable compromise. What his patch does is:

  1. Removes the slack notifications
  2. Preserves the e-mail notifications from travis
  3. Only sends e-mail notifications from travis when builds fail, or when builds transition from fail to success (FIXED)