sangleganesh commented 5 years ago

If we get connection errors when trying to unlock, stopping the refresh routine should be enough since the locks are created with ttl.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a0108bd). Click here to learn what that means. The diff coverage is 71.42%.

@@            Coverage Diff            @@
##             master      #88   +/-   ##
=========================================
  Coverage          ?   68.91%           
=========================================
  Files             ?        7           
  Lines             ?     3423           
  Branches          ?        0           
=========================================
  Hits              ?     2359           
  Misses            ?      828           
  Partials          ?      236

Impacted Files	Coverage Δ
consul/kv_consul.go	`71.13% <100%> (ø)`
consul/client.go	`71.42% <100%> (ø)`
etcd/v3/kv_etcd.go	`67.31% <50%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0108bd...3af3905. Read the comment docs.

sangleganesh commented 4 years ago

done as a part of PR #89

portworx / kvdb

Unlock on conn error #88

Codecov Report