portworx / kvdb

Generic Key-Value interface
Apache License 2.0
40 stars 12 forks source link

quorum wrapper #91

Closed sangleganesh closed 4 years ago

sangleganesh commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #91 into master will increase coverage by 0.73%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   68.59%   69.32%   +0.73%     
==========================================
  Files           7        7              
  Lines        3429     3436       +7     
==========================================
+ Hits         2352     2382      +30     
+ Misses        841      831      -10     
+ Partials      236      223      -13
Impacted Files Coverage Δ
common/common.go 14.28% <0%> (-1.3%) :arrow_down:
etcd/v2/kv_etcd.go 68.45% <0%> (+0.32%) :arrow_up:
etcd/v3/kv_etcd.go 67.51% <0%> (+1.11%) :arrow_up:
consul/kv_consul.go 72.88% <0%> (+1.74%) :arrow_up:
consul/client.go 73.3% <0%> (+1.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3697f6c...980106f. Read the comment docs.

jvinod commented 4 years ago

Can we insert and remove a the no quorum filter in runtime - which will just unconditionally return ErrNoQuorum. The filter will be inserted when we lose quorum and removed when we regain quorum.

sangleganesh commented 4 years ago

Can we insert and remove a the no quorum filter in runtime - which will just unconditionally return ErrNoQuorum. The filter will be inserted when we lose quorum and removed when we regain quorum.

ok, will do.