search

portyanikhin / PyFluids

Simple, full-featured, lightweight CoolProp wrapper for Python
https://pypi.org/project/pyfluids
MIT License
51 stars 2 forks source link

specific_heat, specific_volume - confusing naming, missing values #32

Closed JohK closed 1 year ago

JohK commented 1 year ago

specific_heat is CoolProp.iCpmass, but specific_volume is 1/rho not Coolprop.iCvmass as I would have expected as specific_heat only returns the isobaric value.

What about kappa = Cp/Cv ?

portyanikhin commented 1 year ago

Hello, @JohK!

I don't think the names of these properties are confusing.

specific_heat - mass specific constant pressure specific heat (J/kg/K). specific_volume - mass specific volume (m3/kg).

If you want to add Cv, then it should be called, for example, specific_heat_const_volume, but not specific_volume. Just such a naming would be misleading. Instead of specific_heat I could use specific_heat_const_pressure, but I don't think it's necessary, since the documentation dispels all doubts.

By default, you have only the most frequently used properties. But no one prevents you from adding your own (see the example). I specifically left such an opportunity.