search

porunov / acme_client

Java ACME Client application
MIT License
113 stars 23 forks source link

Request: To Upgrade the acme4j #8

Closed Markandayan1518 closed 6 years ago

Markandayan1518 commented 6 years ago

Now Let’s Encrypt start to support the Wildcard Certificates

porunov commented 6 years ago

Planned to the release 2.2.0

Markandayan1518 commented 6 years ago

thanks a lot for considered my request

porunov commented 6 years ago

You are welcome! Just let this issue to be opened till the feature is implemented.

phelgren commented 6 years ago

I took a look at this myself and would REALLY like to see an update. Unfortunately, the acme4j project isn't documented very well when it came to upgrading from the 1.0 to the 2.0 client and exactly what changed and how. I may continue to try to figure out what to upgrade and how (some looks easy but some of it I didn't see a quick fix). I'll continue to review progress and IF i figure it out and it works, I'll put in a pull request. But, the original author can probably do it quicker than I can

porunov commented 6 years ago

@phelgren Hello, It seems that the upgrade process isn't a simple process and will cause a lot of changes. Right now I am a little bit busy, but I will try to find some time next week. If you can make a PR it would be awesome.

porunov commented 6 years ago

The update from acme v1 to acme v2 have some breaking changes (those protocols have a little bit different certificate generation flow). Particularly in this client there will be removed two commands (renew-certificate and update-agreement). Also the command authorize-domains is now changed to order-certificate command.

I will push the related PR after I manage to update the documentation.

Anyone who would like to test the new client can use the following branch: https://github.com/porunov/acme_client/tree/acme2

You can use --help for additional information.

phelgren commented 6 years ago

Worked like a charm. The command changes meant I needed to change up my scripts but I really appreciated the update. Sorry I could have been of more help...