FontAwesome not published

pos-lifestyle / laravel-nova-collapsible-sidebar

A Laravel Nova collapsible sidebar.

MIT License

5 stars 4 forks source link

FontAwesome not published #2

Open didix16 opened 4 years ago

didix16 commented 4 years ago

Hello. I just installed your package but there seems a problem gathering the font awesome.

As you can see, the icon is not render properly.

The component is trying to get from a URL that Laravel can't reach.

I suggest you that put on your README.md:

Add this line in webpack.mix.js:

.copy("./vendor/pos-lifestyle/laravel-nova-collapsible-sidebar/dist/fonts", "public/fonts")

And then run:

npm run dev

adriaanzon commented 4 years ago

What about using plain SVG Heroicons instead of Font Awesome, as suggested in Nova's documentation? Font Awesome feels like a heavy dependency anyway, considering it's only used for three icons.

The new heroicons set contains several icons this package could use:

chevron left: https://github.com/refactoringui/heroicons/blob/master/dist/solid-sm/sm-cheveron-left.svg?short_path=5b7be8b
chevron right: https://github.com/refactoringui/heroicons/blob/master/dist/solid-sm/sm-cheveron-right.svg?short_path=cf0b5a0
menu: https://github.com/refactoringui/heroicons/blob/master/dist/solid-sm/sm-menu.svg?short_path=9af3fae