search

posativ / acrylamid

(unmaintained) static blog generator in python with incremental rendering ⛺
http://posativ.org/acrylamid/
Other
277 stars 40 forks source link

Various fixes #196

Closed geekman closed 10 years ago

geekman commented 10 years ago

(I'm not sure if I should have split out these fixes into their own issue, or should they be combined like this into a single pull request.)

Various fixes

Wordpress export files contain excerpts which should be extracted into the YAML frontmatter.

The Sitemap view did not remove index.html from the end of the URL before looking up self.mapping, therefore will always fail to match any entries unless they ended with /index.html (which should not be the case).

The "tagify" function was designed to work on a list, but the Link object does not hold additional information, thus tag clouds are constructed manually which has to hardcode the tag view path like this https://github.com/greatghoul/greatghoul.github.io/blob/source/theme/tags.html#L8. With this fix, tagify can be used to construct a single tag link like so {{ tagify(tag.name).href }}.

Lastly, tags passed to the tag view have been safeslug before it reaches the template, thus the template is never able to display the original tag. The original tag name should at least be passed verbatim so that the template can display the original tag name to the user, and if required to construct a link can use safeslug in the template.

posativ commented 10 years ago

Hi,

again, thank you for the patches. The new tag view behavior is much better now. As I do not maintain a blog without directory-index.html nor WordPress I can not test the other two fixes.

geekman commented 10 years ago

Thanks for merging the patches! As I'm porting my Wordpress blog over to acrylamid, I'll try to fix core issues that I encounter. For features that may not be of use to others, I'll be putting them in my own filters and tasks directory.

I'm actually using the Wordpress import myself, so these features are being tested. If anyone encounters a bug, I'll be happy to look at it. As for the sitemap resource changes, they were added in issue #159.