search

pose / webdriver-manager

Fork of Protactor's webdriver-manager as an standalone Node.js module.
22 stars 17 forks source link

Support chromedriver-nw on Windows #15

Open pose opened 9 years ago

pose commented 9 years ago

Related to #14

paulbjensen commented 8 years ago

It looks like the zip file is not being unzipped after the webdriver update call, currently has to be done manually.

pose commented 8 years ago

Hi @paulbjensen, can you tell me which version are you using? Thanks!

paulbjensen commented 8 years ago

Hi, I tried 7.0.1, but I will try 9.0.0 to see if it's fixed further up.

pose commented 8 years ago

@paulbjensen Great, thanks!

paulbjensen commented 8 years ago

HI,

I checked it at 9.0.0, issue still occurs:

PS C:\Users\paulb_000\Documents\GitHub\cross-platform-desktop-applications\chapter-09\lorikeet-nwjs> node_modules/.bin/webdriver-manager update --chromedriver-nw true
Updating selenium standalone
downloading http://selenium-release.storage.googleapis.com/2.52/selenium-server-standalone-2.52.0.jar...
Updating chromedriver (for nwjs)
downloading http://dl.nwjs.io/v0.12.2/chromedriver-nw-v0.13.0-win-x64.zip...
Updating chromedriver
downloading http://chromedriver.storage.googleapis.com/2.21/chromedriver_win32.zip...
Error: Got code 404 from http://dl.nwjs.io/v0.12.2/chromedriver-nw-v0.13.0-win-x64.zip
chromedriver-nw-v0.13.0-win-x64.zip downloaded to C:\Users\paulb_000\Documents\GitHub\cross-platform-desktop-applications\chapter-09\lorikeet-nwjs\node_modules\webdriver-manager\selenium\chromedriver-nw-v0.13.0-win-x64.zip

C:\Users\paulb_000\Documents\GitHub\cross-platform-desktop-applications\chapter-09\lorikeet-nwjs\node_modules\webdriver-manager\node_modules\adm-zip\adm-zip.js:19
           throw Utils.Errors.INVALID_FILENAME;
           ^
Invalid filename

I downloaded the latest webdriver-manager (10.0.2) and that worked fine, but the npm module automatically executes the CLI when loading the module programmatically, hence the desire to use a version pre CLI change.

pose commented 8 years ago

@paulbjensen I can confirm the issue for versions < 9.x but I'll need to research the issue.

About the 10.0.2 module behavior, @cnishina do you know if the npm module executing the CLI is the expected behavior? I've taken a look at the issues and I could not find this reported.