search

poseidon-framework / community-archive

The Poseidon Community Archive (PCA)
https://www.poseidon-adna.org/#/archive_overview
9 stars 25 forks source link

Typo in column names in: `2022_GnecchiRuscone_CarpathianBasin` #166

Closed TCLamnidis closed 5 months ago

TCLamnidis commented 5 months ago

In a group call today, Matthis thor Straten reported that the package 2022_GnecchiRuscone_CarpathianBasin seems to have a typo in the column names.

A custom column named Nr_SNPCoverage_on_Target_SNPs exists, which is likely meant to be Nr_SNPs and Coverage_on_Target_SNPs. We should check if and how this has affected the content of other columns in the package.

stschiff commented 5 months ago

I cannot find that typo.

nevrome commented 5 months ago

It is there - in this line:

https://github.com/poseidon-framework/community-archive/blob/02dac26916f07beda0e421bb236e23fb219aeda2/2022_GnecchiRuscone_CarpathianBasin/2022_GnecchiRuscone_CarpathianBasin.janno#L1

Nr_SNPCoverage_on_Target_SNPs

stschiff commented 5 months ago

But... not in the master branch? Why are we looking at history here? I think I'm missing context.

nevrome commented 5 months ago

I think this is what is on the master branch. My understanding is that 02dac26 just marks the last commit that changed this file.

nevrome commented 5 months ago

No! That would be 1943e47. 02dac26 is just the currently latest commit on the master branch.

stschiff commented 5 months ago

Oh boy, I was looking at the 2024 paper by Guido. Sorry, my bad. Got it.