Create 2021_Posth_SciAdv.janno

EleniSef commented 2 months ago

.janno file for future use.

Posth et al.	Sci Adv	The origin and legacy of the Etruscans through a 2000-year archeogenomic time transect	2021	https://www.science.org/doi/10.1126/sciadv.abi7673

stschiff commented 2 months ago

Brillant @EleniSef, thanks for submitting. We'll take a look.

nevrome commented 1 month ago

Thanks for preparing this .janno file! I see the following issues

[ ] The package name does not follow our expected standard of Year_AuthorName_RelevantKeyword. I propose 2021_Posth_Etruscans.
[ ] Please remove all columns that are completely empty/filled only with n/a.
[ ] The underscores in the location (e.g. Siena_Tuscany), site name or the free text/note columns are not necessary. Spaces are fine. I think something like Siena (Tuscany) would be more natural for the locations.
[ ] Some lat/lon coordinates are unreasonably precise - up to 7 decimal places, which translates to a precision of about 1cm at the equator. 5 decimal places are sufficient.
[ ] The term Chiostraccio man for sample UDC_P sounds like a prime example for an entry in the Alternative_IDs column. I would remove it from the Collection_ID and move it there.
[ ] The entries in Alternative_IDs are often duplicates of the Poseidon_ID. If they're the same, they can be removed.
[ ] The numbers in Coverage_on_Target_SNPs are probably meant to be entries in Nr_SNPs, right?

Maybe you could quickly have a look :+1:

nevrome commented 1 month ago

@EleniSef Remember that you can just modify the data on this branch and do not have to open a new PR. Let me know if this process is unclear.

EleniSef commented 1 month ago

@nevrome Done! I have made all my changes and then committed the changes. Let me know if you have everything you need.

stschiff commented 1 month ago

That is so useful, @EleniSef, as I literally a few days ago received the genotype data from Cosimo. So we can turn this into a package real quick now! Thanks a lot.

TCLamnidis commented 3 weeks ago

@stschiff Where is the genotype data? Should we turn this into a full package?

stschiff commented 3 weeks ago

Yes, that's on my list. Hope to update this soon.

stschiff commented 3 weeks ago

So, thanks again to @EleniSef for preparing this and @nevrome for going through. I will now merge this Janno into a dedicated internal branch (add_2021_Posth_SciAdv), so that I can add the genotype data and move this forward.

stschiff commented 3 weeks ago

(And I will make sure @EleniSef gets credited in the contributor fields, of course!)

poseidon-framework / community-archive

Create 2021_Posth_SciAdv.janno #204