search

poseidon-framework / poseidon-analysis-hs

A tool to analyse genotype data (optionally in the poseidon data format)
MIT License
3 stars 0 forks source link

FST fix and user input robustness #29

Closed stschiff closed 8 months ago

stschiff commented 8 months ago

still in the works.

stschiff commented 8 months ago

OK, @nevrome, this is ready as far as I can tell. Let me know whether you want to review, and I'll wait with merging.

nevrome commented 8 months ago

I suggested some very minor changes to the whitepaper on sharelatex.

stschiff commented 8 months ago

OK, great! I've accepted all those and committed the updated white paper source and PDF already. I will now go through the other comments on the Code you had. And yes, of course we should update the poseidon-hs dependency, an oversight!

stschiff commented 8 months ago

OK, I've updated the dependency on poseidon-hs. I don't think there are any open points now.

nevrome commented 8 months ago

Great! Good to go then :rocket: