Closed nevrome closed 1 year ago
Base: 68.59% // Head: 71.80% // Increases project coverage by +3.21%
:tada:
Coverage data is based on head (
8404f18
) compared to base (500b9e6
). Patch coverage: 64.28% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
OK - I'm merging this now. Further testing of this very change will happen in #226. I'm taking the full responsibility!
v1.1.8.4 (#221) broke the communication between old (before 1.1.8.4) versions of
poseidon-http-server
and new versions oftrident
. This was foreseeable, yet unforeseenThis PR is meant to fix this incompatibility by reverting some of the JSON encoding/decoding related changes. This is not entirely trivial, because we do need a working JSON scheme for
CsvNamedRecord
(which did not exist in the past). To make sure that everything works, we need to consider the following cases:I ran some quick tests on the command line with a local server, and old and new client versions.
Works for all combinations.