search

poseidon-framework / poseidon-hs

A toolset to work with modular genotype databases in the Poseidon format
https://poseidon-framework.github.io/#/trident
MIT License
7 stars 2 forks source link

Generic survey #239

Closed nevrome closed 1 year ago

nevrome commented 1 year ago

This is an idea how to remove the boilerplate from the Survey module. It's advanced magic I barely understand. But it's also super cool and it doesn't tank the compile time. It also shouldn't change the perceived behaviour of trident survey. What do you think, @stschiff?

To make this work as expected I had to adjust the order of the fields in the JannoRow record type.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 95.31% and project coverage change: +0.98 :tada:

Comparison is base (665c9df) 70.36% compared to head (7fa4394) 71.34%.

:exclamation: Current head 7fa4394 differs from pull request most recent head 619d709. Consider uploading reports for the commit 619d709 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #239 +/- ## ========================================== + Coverage 70.36% 71.34% +0.98% ========================================== Files 19 19 Lines 2554 2520 -34 Branches 272 276 +4 ========================================== + Hits 1797 1798 +1 + Misses 485 446 -39 - Partials 272 276 +4 ``` | [Impacted Files](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework) | Coverage Δ | | |---|---|---| | [src/Poseidon/CLI/Survey.hs](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework#diff-c3JjL1Bvc2VpZG9uL0NMSS9TdXJ2ZXkuaHM=) | `80.64% <89.47%> (-8.83%)` | :arrow_down: | | [src/Poseidon/Janno.hs](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework#diff-c3JjL1Bvc2VpZG9uL0phbm5vLmhz) | `82.41% <97.77%> (+0.19%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stschiff commented 1 year ago

Hmm, interesting. OK, I'd like to take a closer look at this trickery.