poseidon-framework / poseidon-hs

A toolset to work with modular genotype databases in the Poseidon format
https://poseidon-framework.github.io/#/trident
MIT License
7 stars 2 forks source link

started upgrading to lts-20.17 #242

Closed stschiff closed 1 year ago

stschiff commented 1 year ago

I'm just putting this here for now. The build plan works, but we needed to get rid of yaml-pretty-extras. The newer yaml packages support tweaking the output order, though: https://stackoverflow.com/a/65659340

So that's something to be changed.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 94.87% and project coverage change: -0.14 :warning:

Comparison is base (ba73946) 70.49% compared to head (665c9df) 70.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #242 +/- ## ========================================== - Coverage 70.49% 70.36% -0.14% ========================================== Files 19 19 Lines 2552 2554 +2 Branches 268 272 +4 ========================================== - Hits 1799 1797 -2 Misses 485 485 - Partials 268 272 +4 ``` | [Impacted Files](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework) | Coverage Δ | | |---|---|---| | [src/Poseidon/CLI/Fetch.hs](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework#diff-c3JjL1Bvc2VpZG9uL0NMSS9GZXRjaC5ocw==) | `51.63% <0.00%> (-0.82%)` | :arrow_down: | | [src/Poseidon/Package.hs](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework#diff-c3JjL1Bvc2VpZG9uL1BhY2thZ2UuaHM=) | `72.37% <96.66%> (-0.32%)` | :arrow_down: | | [src/Poseidon/CLI/Forge.hs](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework#diff-c3JjL1Bvc2VpZG9uL0NMSS9Gb3JnZS5ocw==) | `68.05% <100.00%> (ø)` | | | [src/Poseidon/CLI/Genoconvert.hs](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework#diff-c3JjL1Bvc2VpZG9uL0NMSS9HZW5vY29udmVydC5ocw==) | `57.35% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/poseidon-framework/poseidon-hs/pull/242/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nevrome commented 1 year ago

I decided to move even further into the presence to LTS 20.17 for ghc-9.2.7, published a week ago. I then went ahead and replaced the yaml-pretty-extras code. I also fixed all compiler issues with --pedantic: Some of our pattern matches are not allowed any more.

I think this is ready and can be reviewed/merged. I'll have quick peak into the release pipeline now to fix obvious issues. But we'll only know if everything works when we prepare the next release :shrug:

stschiff commented 1 year ago

Wow, I did only just see this. Fantastic. Then I can compile this on my new Mac as well. I will try and green-light this tonight