Closed nevrome closed 1 year ago
Patch coverage: 57.89
% and project coverage change: -0.64
:warning:
Comparison is base (
5ccae44
) 69.86% compared to head (419910f
) 69.23%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I didn't test any of the potential error states. For the janno code we have some tests for these, but also no fully comprehensive system. I think it's OK to leave it like that for now, but my arguments are weak:
Maybe we do a test-hackathon one day to get to 90+%
Working though the validation of real world .ssf files provided by @93Boy in https://github.com/poseidon-framework/published_data/pull/114/ exposed various flaws in trident and the Poseidon schema (e.g. https://github.com/poseidon-framework/poseidon2-schema/issues/61). In this PR I will collect the changes necessary to trident in anticipation of changes to the schema.