poseidon-framework / poseidon-hs

A toolset to work with modular genotype databases in the Poseidon format
https://poseidon-framework.github.io/#/trident
MIT License
7 stars 2 forks source link

reworked API field names #255

Closed nevrome closed 1 year ago

nevrome commented 1 year ago

A suggestion for more consistent API field names. image image image

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.01 :tada:

Comparison is base (1a4bb1d) 68.81% compared to head (3c582a7) 68.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #255 +/- ## ========================================== + Coverage 68.81% 68.83% +0.01% ========================================== Files 20 20 Lines 2883 2881 -2 Branches 309 308 -1 ========================================== - Hits 1984 1983 -1 Misses 590 590 + Partials 309 308 -1 ``` | [Impacted Files](https://app.codecov.io/gh/poseidon-framework/poseidon-hs/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework) | Coverage Δ | | |---|---|---| | [src/Poseidon/SecondaryTypes.hs](https://app.codecov.io/gh/poseidon-framework/poseidon-hs/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=poseidon-framework#diff-c3JjL1Bvc2VpZG9uL1NlY29uZGFyeVR5cGVzLmhz) | `68.42% <93.33%> (+0.21%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stschiff commented 1 year ago

And I think as soon as this is merged, we should make a release, right? Or rather, after some testing, and using fetch all on our cluster.

nevrome commented 1 year ago

OK, I like the new naming.

I can see why you wanted to flatten the GroupInfo JSON instances. It's OK for me, but then you should remove the JSON instances from PacNameAndVersion, as that type is not anymore used for JSON serialization.

Otherwise I approve this.

Done.