Closed nevrome closed 1 year ago
Patch coverage: 93.33
% and project coverage change: +0.01
:tada:
Comparison is base (
1a4bb1d
) 68.81% compared to head (3c582a7
) 68.83%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
And I think as soon as this is merged, we should make a release, right? Or rather, after some testing, and using fetch all
on our cluster.
OK, I like the new naming.
I can see why you wanted to flatten the GroupInfo JSON instances. It's OK for me, but then you should remove the JSON instances from
PacNameAndVersion
, as that type is not anymore used for JSON serialization.Otherwise I approve this.
Done.
A suggestion for more consistent API field names.