Closed stschiff closed 1 year ago
Patch coverage: 1.09%
and project coverage change: -8.70%
:warning:
Comparison is base (
0570251
) 70.78% compared to head (ee288c0
) 62.09%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good :+1:
The test infrastructure in poseidon-analysis-hs was different than here. Maybe we want to unify that at some point, but if it all runs through it's fine for me. The .Rhistory
file in manual_tests_xerxes
should probably be added to the .gitignore.
How do we version xerxes from now on? Is there just one trident/xerxes version then? Or shall we try to establish a separate versioning system for the library and the two executables? Cabal/stack are not particularly helpful here.
Independent of that I think this warrants a change in the major version number. Maybe even in the era number.
I removed the .Rhistory file. It was in fact historic.
I think Xerxes will follow the same versioning now as trident. That is - in my view - the condition that comes with merging it into one repository. Otherwise we have to introduce a separate versioning from the one in the cabal-file, and I fear that will get quite obfuscating.
Regarding the major version number, I agree. I have no opinion on the era-number, though I am a little afraid it might cause all too large expectations 😅
OK, I have increased the first version number now, let's be bold.
Regarding the tests, just wanted to say that for FStats we have to do some manual tests, since I want to make sure that the results are similar to what previous tools, including Nick's admix tools gives. Those runs are too long to automate.
Let me know if there is anything else.
We'll close this for now. Was not a good idea for now.
Still a draft, but integration was fairly easy. I will work on some tests now.